Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Rocket-lite Navigation Bar review #3619

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 29, 2022

What do these changes do?

Once the user starts a study in the rocket-lite product, since the service starts in full screen mode, many functionalities get hidden. This PR brings the most important ones to the Navigation Bar:

  • Dashboard button with home icon
  • Edit study name
  • Information button with study-service merged info (in menu)
  • Download logs (in menu)

NavBar

Related issue/s

Improves Full Screen UX ITISFoundation/osparc-issues#765

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Nov 29, 2022
@odeimaiz odeimaiz added this to the Athena milestone Nov 29, 2022
@odeimaiz odeimaiz self-assigned this Nov 29, 2022
@odeimaiz odeimaiz changed the title Rocket lite review ✨ Rocket lite review Nov 29, 2022
@odeimaiz odeimaiz changed the title ✨ Rocket lite review ✨ Rocket lite Navigation Bar review Nov 29, 2022
@odeimaiz odeimaiz changed the title ✨ Rocket lite Navigation Bar review ✨ Rocket-lite Navigation Bar review Nov 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz marked this pull request as ready for review December 1, 2022 15:27
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thanks!

@odeimaiz odeimaiz merged commit 0323aaa into ITISFoundation:master Dec 1, 2022
@odeimaiz odeimaiz deleted the feature/s4l-lite-study-editor branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants